Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polish(nyz): polish atari envpool demo #702

Closed
wants to merge 1 commit into from
Closed

polish(nyz): polish atari envpool demo #702

wants to merge 1 commit into from

Conversation

PaParaZz1
Copy link
Member

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the env Questions about RL environment label Aug 10, 2023
@PaParaZz1 PaParaZz1 requested a review from zjowowen August 10, 2023 11:14
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #702 (e809189) into main (6b188c9) will decrease coverage by 1.06%.
Report is 13 commits behind head on main.
The diff coverage is 52.24%.

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   82.06%   81.00%   -1.06%     
==========================================
  Files         586      595       +9     
  Lines       47515    49440    +1925     
==========================================
+ Hits        38991    40051    +1060     
- Misses       8524     9389     +865
Flag Coverage Δ
unittests 81.00% <52.24%> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ding/envs/env_manager/envpool_env_manager.py 36.90% <0.00%> (+0.31%) ⬆️
ding/policy/edac.py 18.26% <ø> (ø)
ding/policy/mbpolicy/mbsac.py 95.75% <ø> (ø)
...r/collector/battle_interaction_serial_evaluator.py 93.79% <ø> (ø)
ding/entry/serial_entry_mbrl.py 75.18% <4.00%> (-16.48%) ⬇️
ding/worker/replay_buffer/naive_buffer.py 75.31% <13.95%> (-13.47%) ⬇️
ding/policy/mbpolicy/utils.py 25.00% <14.28%> (-75.00%) ⬇️
ding/policy/mbpolicy/dreamer.py 16.48% <16.48%> (ø)
ding/envs/env_manager/base_env_manager.py 88.21% <33.33%> (+0.41%) ⬆️
ding/model/template/vac.py 75.21% <35.71%> (-5.37%) ⬇️
... and 33 more

... and 223 files with indirect coverage changes

@PaParaZz1 PaParaZz1 mentioned this pull request Aug 9, 2023
Open
@PaParaZz1
Copy link
Member Author

This PR will be updated in #746

@PaParaZz1 PaParaZz1 closed this Nov 1, 2023
@PaParaZz1 PaParaZz1 deleted the dev-fix-envpool branch November 1, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjowowen zjowowen Awaiting requested review from zjowowen

Assignees
No one assigned
Labels
env Questions about RL environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PaParaZz1